netdev - Re: [PATCH v7 16/16] PCI/pwrctl: add a PCI power control driver for power sequenced devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c128cf9b-de30-49f1-9adb-8b03b61f4d51@quicinc.com>
Date: Wed, 10 Apr 2024 09:05:26 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
        Marcel Holtmann
	<marcel@...tmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "David
 S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Kalle Valo <kvalo@...nel.org>,
        Bjorn
 Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Catalin
 Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Bjorn
 Helgaas <bhelgaas@...gle.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Geert
 Uytterhoeven <geert+renesas@...der.be>,
        Arnd Bergmann <arnd@...db.de>,
        Neil
 Armstrong <neil.armstrong@...aro.org>,
        Marek Szyprowski
	<m.szyprowski@...sung.com>,
        Alex Elder <elder@...aro.org>,
        Srini Kandagatla
	<srinivas.kandagatla@...aro.org>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Abel Vesa <abel.vesa@...aro.org>,
        Manivannan
 Sadhasivam <mani@...nel.org>,
        Lukas Wunner <lukas@...ner.de>,
        Dmitry
 Baryshkov <dmitry.baryshkov@...aro.org>,
        Amit Pundir
	<amit.pundir@...aro.org>, Xilin Wu <wuxilin123@...il.com>
CC: <linux-bluetooth@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-wireless@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-pci@...r.kernel.org>,
        <linux-pm@...r.kernel.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v7 16/16] PCI/pwrctl: add a PCI power control driver for
 power sequenced devices

On 4/10/2024 5:46 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Add a PCI power control driver that's capable of correctly powering up
> devices using the power sequencing subsystem. The first user of this
> driver is the ath11k module on QCA6390.
[...]
> +config PCI_PWRCTL_PWRSEQ
> +	tristate "PCI Power Control driver using the Power Sequencing subsystem"
> +	select POWER_SEQUENCING
> +	select PCI_PWRCTL
> +	default m if (ATH11K_PCI && ARCH_QCOM)
[...]
> +static const struct of_device_id pci_pwrctl_pwrseq_of_match[] = {
> +	{
> +		/* ATH11K in QCA6390 package. */
> +		.compatible = "pci17cb,1101",
> +		.data = "wlan",
> +	},
> +	{
> +		/* ATH12K in WCN7850 package. */
> +		.compatible = "pci17cb,1107",
> +		.data = "wlan",

since you are adding both ath11k and ath12k packages, should you update the
commit text and the config "default m if" condition to include ath12k?

/jeff