netdev - Re: [PATCH net-next] flow_offload: fix flow_offload_has_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9abe0c09-efa5-4ff4-b423-469a2dd34ef8@amd.com>
Date: Thu, 11 Apr 2024 12:32:44 +0100
From: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next] flow_offload: fix flow_offload_has_one_action()
 kdoc

[Removed my old email address from CC]

This LGTM, thank you.

Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>

On 10/04/2024 12:47, Asbjørn Sloth Tønnesen wrote:
> include/net/flow_offload.h:351: warning:
>   No description found for return value of 'flow_offload_has_one_action'
> 
> Fixes: ab79af32b0a5 ("mlxsw: use intermediate representation for matchall offload")
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
> ---
>  include/net/flow_offload.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 314087a5e1818..7726b4a97050e 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -345,7 +345,7 @@ static inline bool flow_action_has_entries(const struct flow_action *action)
>   * flow_offload_has_one_action() - check if exactly one action is present
>   * @action: tc filter flow offload action
>   *
> - * Returns true if exactly one action is present.
> + * Return: true if exactly one action is present.
>   */
>  static inline bool flow_offload_has_one_action(const struct flow_action *action)
>  {