netdev - RE: [PATCH net-next v5 2/2] nfp: update devlink device info output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB508971B64D360D27424F9E3DD6052@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Thu, 11 Apr 2024 16:10:19 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Louis Peens <louis.peens@...igine.com>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>, Fei Qin
	<fei.qin@...igine.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"oss-drivers@...igine.com" <oss-drivers@...igine.com>
Subject: RE: [PATCH net-next v5 2/2] nfp: update devlink device info output



> -----Original Message-----
> From: Louis Peens <louis.peens@...igine.com>
> Sent: Wednesday, April 10, 2024 11:19 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: David Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; Jiri Pirko <jiri@...nulli.us>; Fei Qin
> <fei.qin@...igine.com>; netdev@...r.kernel.org; oss-drivers@...igine.com
> Subject: Re: [PATCH net-next v5 2/2] nfp: update devlink device info output
> 
> On Wed, Apr 10, 2024 at 03:27:22PM -0700, Jacob Keller wrote:
> >
> >
> > On 4/10/2024 4:26 AM, Louis Peens wrote:
> > > From: Fei Qin <fei.qin@...igine.com>
> > >
> > > Newer NIC will introduce a new part number, now add it
> > > into devlink device info.
> > >
> > > This patch also updates the information of "board.id" in
> > > nfp.rst to match the devlink-info.rst.
> > >
> >
> > I was a bit confused since you didn't update the board.id to reference
> > something else. I am guessing in newer images, the "assembly.partno"
> > would be different from "pn"?
> 
> Hi - yes, they would be two different things, approximate example for
> new images:
>     board.id ~ AMDA2001-1003
>     board.part_number ~ CGX11-A2PSNM
> 
> Old images will just have board.id. The field naming we get from the
> hardware is indeed slightly confusing, but since they are used
> differently we could not just update board.id.
> 
> I hope this clears things up.
> 

Yes, thanks! It might be helpful to include examples of actual values in the doc.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> Regards
> Louis
> >
> > Thanks,
> > Jake