netdev - Re: [net-next:main 26/50] net/ipv4/tcp.c:4673:2: error: call to '__compiletime_assert_1030' declared with 'error' attribute: BUILD_BUG_ON failed: offsetof(struct tcp_sock, __cacheline_group_end__tcp_sock_write_txrx) - offsetofend(struct tcp_sock, __cacheline_group_begin__tcp_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a59e2164-7159-445e-9f87-fcf6cb4b57d6@gmail.com>
Date: Thu, 11 Apr 2024 12:21:22 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>
Cc: Vladimir Oltean <olteanv@...il.com>, kernel test robot <lkp@...el.com>,
 llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [net-next:main 26/50] net/ipv4/tcp.c:4673:2: error: call to
 '__compiletime_assert_1030' declared with 'error' attribute: BUILD_BUG_ON
 failed: offsetof(struct tcp_sock, __cacheline_group_end__tcp_sock_write_txrx)
 - offsetofend(struct tcp_sock, __cacheline_group_begin__tcp_sock_...

On 4/10/24 18:36, Jakub Kicinski wrote:
> On Wed, 10 Apr 2024 19:33:54 +0200 Eric Dumazet wrote:
>>> Jakub, I do not see a 32-bit build in the various checks being run for a
>>> patch, could you add one, if nothing else a i386 build and a
>>> multi_v7_defconfig build would get us a good build coverage.
>>
>> i386 build was just fine for me.
> 
> Yes, we test i386 too, FWIW.
> 
> Florian, does arm32 break a lot? I may not be paying sufficient
> attention. We can add more build tests but the CPU time we have
> is unfortunately finite :(

Yes, that is why I mentioned multi_v7_defconfig, you an see the build 
failure with that configuration. Of course Eric fixed it now, thanks!
-- 
Florian