netdev - Re: [PATCH v3 3/6] s390: Stop using weak symbols for __iowrite64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <65a7d714-1004-4ba3-9c03-7c691f3c3dc7@app.fastmail.com>
Date: Thu, 11 Apr 2024 22:23:34 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jason Gunthorpe" <jgg@...dia.com>,
 "Alexander Gordeev" <agordeev@...ux.ibm.com>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Christian Borntraeger" <borntraeger@...ux.ibm.com>,
 "Borislav Petkov" <bp@...en8.de>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>,
 "David S . Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>,
 "Gerald Schaefer" <gerald.schaefer@...ux.ibm.com>,
 "Vasily Gorbik" <gor@...ux.ibm.com>,
 "Heiko Carstens" <hca@...ux.ibm.com>, "H. Peter Anvin" <hpa@...or.com>,
 "Justin Stitt" <justinstitt@...gle.com>,
 "Jakub Kicinski" <kuba@...nel.org>, "Leon Romanovsky" <leon@...nel.org>,
 linux-rdma@...r.kernel.org, linux-s390@...r.kernel.org,
 llvm@...ts.linux.dev, "Ingo Molnar" <mingo@...hat.com>,
 "Bill Wendling" <morbo@...gle.com>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Nick Desaulniers" <ndesaulniers@...gle.com>,
 Netdev <netdev@...r.kernel.org>, "Paolo Abeni" <pabeni@...hat.com>,
 "Salil Mehta" <salil.mehta@...wei.com>,
 "Sven Schnelle" <svens@...ux.ibm.com>,
 "Thomas Gleixner" <tglx@...utronix.de>, x86@...nel.org,
 "Yisen Zhuang" <yisen.zhuang@...wei.com>
Cc: "Catalin Marinas" <catalin.marinas@....com>,
 "Leon Romanovsky" <leonro@...lanox.com>,
 Linux-Arch <linux-arch@...r.kernel.org>,
 linux-arm-kernel@...ts.infradead.org, "Mark Rutland" <mark.rutland@....com>,
 "Michael Guralnik" <michaelgur@...lanox.com>, patches@...ts.linux.dev,
 "Niklas Schnelle" <schnelle@...ux.ibm.com>,
 "Jijie Shao" <shaojijie@...wei.com>, "Will Deacon" <will@...nel.org>
Subject: Re: [PATCH v3 3/6] s390: Stop using weak symbols for __iowrite64_copy()

On Thu, Apr 11, 2024, at 18:46, Jason Gunthorpe wrote:
> Complete switching the __iowriteXX_copy() routines over to use #define and
> arch provided inline/macro functions instead of weak symbols.
>
> S390 has an implementation that simply calls another memcpy
> function. Inline this so the callers don't have to do two jumps.
>
> Acked-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> Signed-off-by: Jason Gunthorpe <jgg@...dia.com>
> ---
>  arch/s390/include/asm/io.h | 7 +++++++
>  arch/s390/pci/pci.c        | 6 ------
>  include/linux/io.h         | 3 +++
>  lib/iomap_copy.c           | 7 +++----
>  4 files changed, 13 insertions(+), 10 deletions(-)

For the common code bits:

Acked-by: Arnd Bergmann <arnd@...db.de>

> -void __attribute__((weak)) __iowrite64_copy(void __iomem *to,
> -					    const void *from,
> -					    size_t count)
> +#ifndef __iowrite64_copy
> +void __iowrite64_copy(void __iomem *to, const void *from, size_t count)
>  {

I'm always happy to see __weak functions get cleaned up.

      Arnd