netdev - Re: [PATCH net V2 12/12] net/mlx5: SD, Handle possible devcom ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240410195246.3ea983da@kernel.org>
Date: Wed, 10 Apr 2024 19:52:46 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Tariq Toukan
 <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
 netdev@...r.kernel.org, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
 <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH net V2 12/12] net/mlx5: SD, Handle possible devcom
 ERR_PTR

On Wed, 10 Apr 2024 21:16:37 +0300 Tariq Toukan wrote:
> Touching mlx5_devcom_register_component() as a fix for commit 
> d3d057666090 ("net/mlx5: SD, Implement devcom communication and primary 
> election") doesn't look right to me.
> In addition, I prefer minimal fixes to net.
> 
> After this one is accepted to net, we can enhance the code in a followup 
> patch to net-next.

I think the official guidance from Greg is "fix it right, worry about
size of the change when stable backport fails".
mlx5_devcom_register_component() has 4 callers, please follow Dan's advice.
I'll apply other 11 patches.