netdev - Re: [PATCH net-next v9 1/6] net: stmmac: Add multi-channel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fd50d0f-862f-5aa1-700c-a2a4fe01854f@bootlin.com>
Date: Thu, 11 Apr 2024 09:26:04 +0200 (CEST)
From: Romain Gantois <romain.gantois@...tlin.com>
To: Yanteng Si <siyanteng@...ngson.cn>
cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com, 
    alexandre.torgue@...s.st.com, joabreu@...opsys.com, 
    fancer.lancer@...il.com, Jose.Abreu@...opsys.com, chenhuacai@...ngson.cn, 
    linux@...linux.org.uk, guyinggang@...ngson.cn, netdev@...r.kernel.org, 
    chris.chenfeiyang@...il.com, siyanteng01@...il.com
Subject: Re: [PATCH net-next v9 1/6] net: stmmac: Add multi-channel support

Hello Yanteng,

On Sat, 6 Apr 2024, Yanteng Si wrote:

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> index e1537a57815f..e94faa72f30e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
> @@ -420,6 +420,12 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev,
>  		return 0;
>  	}
>  
> +	if (priv->plat->flags & STMMAC_FLAG_DISABLE_FORCE_1000) {
> +		if (cmd->base.speed == SPEED_1000 &&
> +		    cmd->base.autoneg != AUTONEG_ENABLE)
> +			return -EOPNOTSUPP;
> +	}
> +
>  	return phylink_ethtool_ksettings_set(priv->phylink, cmd);
>  }

This doesn't seem like it belongs with the rest of the changes in this patch. 
Maybe you could move it to a separate patch?

Best Regards,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com