netdev - Re: [PATCH net] octeontx2-pf: fix FLOW_DIS_IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <235918fc-9b9b-4efa-8258-69bd5c7d40d4@fiberby.net>
Date: Fri, 12 Apr 2024 10:25:30 +0000
From: Asbjørn Sloth Tønnesen <ast@...erby.net>
To: Suman Ghosh <sumang@...vell.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>,
 Geethasowjanya Akula <gakula@...vell.com>,
 Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Hariprasad Kelam <hkelam@...vell.com>
Subject: Re: [PATCH net] octeontx2-pf: fix FLOW_DIS_IS_FRAGMENT implementation

Hi again,

On 4/12/24 9:01 AM, Asbjørn Sloth Tønnesen wrote:
> There are therefore 3 possible cases:
> 
> - `tc flower ...` (no ip_flags frag or nofrag)
>     (match.key->flags & FLOW_DIS_FIRST_FRAG)  is false
>     (match.mask->flags & FLOW_DIS_FIRST_FRAG) is false
> 
> - `tc flower ... ip_flags nofrag`
>     (match.key->flags & FLOW_DIS_FIRST_FRAG)  is false
>     (match.mask->flags & FLOW_DIS_FIRST_FRAG) is true
> 
> - `tc flower ... ip_flags frag`
>     (match.key->flags & FLOW_DIS_FIRST_FRAG)  is true
>     (match.mask->flags & FLOW_DIS_FIRST_FRAG) is true

I was a bit a hurry, to get the reply in before a meeting,
so: s/FLOW_DIS_FIRST_FRAG/FLOW_DIS_IS_FRAGMENT/g

There are therefore 3 possible cases:

- `tc flower ...` (no ip_flags frag or nofrag)
    (match.key->flags & FLOW_DIS_IS_FRAGMENT)  is false
    (match.mask->flags & FLOW_DIS_IS_FRAGMENT) is false

- `tc flower ... ip_flags nofrag`
    (match.key->flags & FLOW_DIS_IS_FRAGMENT)  is false
    (match.mask->flags & FLOW_DIS_IS_FRAGMENT) is true

- `tc flower ... ip_flags frag`
    (match.key->flags & FLOW_DIS_IS_FRAGMENT)  is true
    (match.mask->flags & FLOW_DIS_IS_FRAGMENT) is true

-- 
Best regards
Asbjørn Sloth Tønnesen
Network Engineer
Fiberby - AS42541