netdev - Re: [PATCH iproute2-next 2/2] f_flower: implement pfcp opts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e6ede0f-2505-4c29-94da-c96e97bad78e@gmail.com>
Date: Fri, 12 Apr 2024 08:41:27 -0600
From: David Ahern <dsahern@...il.com>
To: Wojciech Drewek <wojciech.drewek@...el.com>,
 Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next 2/2] f_flower: implement pfcp opts

On 4/11/24 5:32 AM, Wojciech Drewek wrote:
> 
> 
> On 10.04.2024 17:53, Stephen Hemminger wrote:
>> On Wed, 10 Apr 2024 12:14:40 +0200
>> Wojciech Drewek <wojciech.drewek@...el.com> wrote:
>>
>>> +pfcp_opts
>>> +.I OPTIONS
>>> +doesn't support multiple options, and it consists of a key followed by a slash
>>> +and corresponding mask. If the mask is missing, \fBtc\fR assumes a full-length
>>> +match. The option can be described in the form TYPE:SEID/TYPE_MASK:SEID_MASK
>>> +where TYPE is represented as a 8bit number, SEID is represented by 64bit, both
>>> +of them are in hex.
>>
>> Best practices in English writing style is to make all clauses have similar
>> starting phrase.
> 
> pfcp_opts
> .I OPTIONS
> doesn't support multiple options. It consists of a key followed by a slash
> and corresponding mask. If the mask is missing, \fBtc\fR assumes a full-length
> match. The option can be described in the form TYPE:SEID/TYPE_MASK:SEID_MASK
> where TYPE is represented as a 8bit number, SEID is represented by 64bit. Both
> TYPE and SEID are provided in hex.

expand the contraction (doen't -> does not); otherwise I am fine with it