lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202404130138.7jOMaraz-lkp@intel.com>
Date: Sat, 13 Apr 2024 01:44:00 +0800
From: kernel test robot <lkp@...el.com>
To: Heng Qi <hengqi@...ux.alibaba.com>, netdev@...r.kernel.org,
	virtualization@...ts.linux.dev
Cc: oe-kbuild-all@...ts.linux.dev, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Ratheesh Kannoth <rkannoth@...vell.com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Subject: Re: [PATCH net-next v6 2/4] ethtool: provide customized dim profile
 management

Hi Heng,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/linux-dim-move-useful-macros-to-h-file/20240411-221400
base:   net-next/main
patch link:    https://lore.kernel.org/r/1712844751-53514-3-git-send-email-hengqi%40linux.alibaba.com
patch subject: [PATCH net-next v6 2/4] ethtool: provide customized dim profile management
config: openrisc-defconfig (https://download.01.org/0day-ci/archive/20240413/202404130138.7jOMaraz-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240413/202404130138.7jOMaraz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404130138.7jOMaraz-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/core/dev.c: In function 'dev_dim_profile_init':
>> net/core/dev.c:10235:63: error: 'struct net_device' has no member named 'rx_eqe_profile'
   10235 |         int length = NET_DIM_PARAMS_NUM_PROFILES * sizeof(*dev->rx_eqe_profile);
         |                                                               ^~
   net/core/dev.c:10242:20: error: 'struct net_device' has no member named 'rx_eqe_profile'
   10242 |                 dev->rx_eqe_profile = kzalloc(length, GFP_KERNEL);
         |                    ^~
   net/core/dev.c:10243:25: error: 'struct net_device' has no member named 'rx_eqe_profile'
   10243 |                 if (!dev->rx_eqe_profile)
         |                         ^~
   net/core/dev.c:10245:27: error: 'struct net_device' has no member named 'rx_eqe_profile'
   10245 |                 memcpy(dev->rx_eqe_profile, rx_profile[0], length);
         |                           ^~
>> net/core/dev.c:10248:20: error: 'struct net_device' has no member named 'rx_cqe_profile'
   10248 |                 dev->rx_cqe_profile = kzalloc(length, GFP_KERNEL);
         |                    ^~
   net/core/dev.c:10249:25: error: 'struct net_device' has no member named 'rx_cqe_profile'
   10249 |                 if (!dev->rx_cqe_profile)
         |                         ^~
   net/core/dev.c:10251:27: error: 'struct net_device' has no member named 'rx_cqe_profile'
   10251 |                 memcpy(dev->rx_cqe_profile, rx_profile[1], length);
         |                           ^~
>> net/core/dev.c:10254:20: error: 'struct net_device' has no member named 'tx_eqe_profile'
   10254 |                 dev->tx_eqe_profile = kzalloc(length, GFP_KERNEL);
         |                    ^~
   net/core/dev.c:10255:25: error: 'struct net_device' has no member named 'tx_eqe_profile'
   10255 |                 if (!dev->tx_eqe_profile)
         |                         ^~
   net/core/dev.c:10257:27: error: 'struct net_device' has no member named 'tx_eqe_profile'
   10257 |                 memcpy(dev->tx_eqe_profile, tx_profile[0], length);
         |                           ^~
>> net/core/dev.c:10260:20: error: 'struct net_device' has no member named 'tx_cqe_profile'
   10260 |                 dev->tx_cqe_profile = kzalloc(length, GFP_KERNEL);
         |                    ^~
   net/core/dev.c:10261:25: error: 'struct net_device' has no member named 'tx_cqe_profile'
   10261 |                 if (!dev->tx_cqe_profile)
         |                         ^~
   net/core/dev.c:10263:27: error: 'struct net_device' has no member named 'tx_cqe_profile'
   10263 |                 memcpy(dev->tx_cqe_profile, tx_profile[1], length);
         |                           ^~
   net/core/dev.c: In function 'netif_free_profile':
   net/core/dev.c:11063:26: error: 'struct net_device' has no member named 'rx_eqe_profile'
   11063 |                 kfree(dev->rx_eqe_profile);
         |                          ^~
   net/core/dev.c:11066:26: error: 'struct net_device' has no member named 'rx_cqe_profile'
   11066 |                 kfree(dev->rx_cqe_profile);
         |                          ^~
   net/core/dev.c:11069:26: error: 'struct net_device' has no member named 'tx_eqe_profile'
   11069 |                 kfree(dev->tx_eqe_profile);
         |                          ^~
   net/core/dev.c:11072:26: error: 'struct net_device' has no member named 'tx_cqe_profile'
   11072 |                 kfree(dev->tx_cqe_profile);
         |                          ^~
--
   net/ethtool/coalesce.c: In function 'coalesce_fill_reply':
>> net/ethtool/coalesce.c:268:37: error: 'struct net_device' has no member named 'rx_eqe_profile'
     268 |                                  dev->rx_eqe_profile, supported) ||
         |                                     ^~
>> net/ethtool/coalesce.c:270:37: error: 'struct net_device' has no member named 'rx_cqe_profile'
     270 |                                  dev->rx_cqe_profile, supported) ||
         |                                     ^~
>> net/ethtool/coalesce.c:272:37: error: 'struct net_device' has no member named 'tx_eqe_profile'
     272 |                                  dev->tx_eqe_profile, supported) ||
         |                                     ^~
>> net/ethtool/coalesce.c:274:37: error: 'struct net_device' has no member named 'tx_cqe_profile'
     274 |                                  dev->tx_cqe_profile, supported))
         |                                     ^~
   net/ethtool/coalesce.c: In function '__ethnl_set_coalesce':
   net/ethtool/coalesce.c:479:44: error: 'struct net_device' has no member named 'rx_eqe_profile'
     479 |         ret = ethnl_update_profile(dev, dev->rx_eqe_profile,
         |                                            ^~
   net/ethtool/coalesce.c:484:44: error: 'struct net_device' has no member named 'rx_cqe_profile'
     484 |         ret = ethnl_update_profile(dev, dev->rx_cqe_profile,
         |                                            ^~
   net/ethtool/coalesce.c:489:44: error: 'struct net_device' has no member named 'tx_eqe_profile'
     489 |         ret = ethnl_update_profile(dev, dev->tx_eqe_profile,
         |                                            ^~
   net/ethtool/coalesce.c:494:44: error: 'struct net_device' has no member named 'tx_cqe_profile'
     494 |         ret = ethnl_update_profile(dev, dev->tx_cqe_profile,
         |                                            ^~


vim +10235 net/core/dev.c

 10232	
 10233	static int dev_dim_profile_init(struct net_device *dev)
 10234	{
 10235		int length = NET_DIM_PARAMS_NUM_PROFILES * sizeof(*dev->rx_eqe_profile);
 10236		u32 supported = dev->ethtool_ops->supported_coalesce_params;
 10237	
 10238		if (!(dev->priv_flags & (IFF_PROFILE_USEC | IFF_PROFILE_PKTS | IFF_PROFILE_COMPS)))
 10239			return 0;
 10240	
 10241		if (supported & ETHTOOL_COALESCE_RX_EQE_PROFILE) {
 10242			dev->rx_eqe_profile = kzalloc(length, GFP_KERNEL);
 10243			if (!dev->rx_eqe_profile)
 10244				return -ENOMEM;
 10245			memcpy(dev->rx_eqe_profile, rx_profile[0], length);
 10246		}
 10247		if (supported & ETHTOOL_COALESCE_RX_CQE_PROFILE) {
 10248			dev->rx_cqe_profile = kzalloc(length, GFP_KERNEL);
 10249			if (!dev->rx_cqe_profile)
 10250				return -ENOMEM;
 10251			memcpy(dev->rx_cqe_profile, rx_profile[1], length);
 10252		}
 10253		if (supported & ETHTOOL_COALESCE_TX_EQE_PROFILE) {
 10254			dev->tx_eqe_profile = kzalloc(length, GFP_KERNEL);
 10255			if (!dev->tx_eqe_profile)
 10256				return -ENOMEM;
 10257			memcpy(dev->tx_eqe_profile, tx_profile[0], length);
 10258		}
 10259		if (supported & ETHTOOL_COALESCE_TX_CQE_PROFILE) {
 10260			dev->tx_cqe_profile = kzalloc(length, GFP_KERNEL);
 10261			if (!dev->tx_cqe_profile)
 10262				return -ENOMEM;
 10263			memcpy(dev->tx_cqe_profile, tx_profile[1], length);
 10264		}
 10265	
 10266		return 0;
 10267	}
 10268	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ