netdev - Re: [PATCH net] inet: bring NLM_DONE out to a separate recv() again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240412200353.3bccfc85@elisabeth>
Date: Fri, 12 Apr 2024 20:03:53 +0200
From: Stefano Brivio <sbrivio@...hat.com>
To: Ilya Maximets <i.maximets@....org>
Cc: Jakub Kicinski <kuba@...nel.org>, David Ahern <dsahern@...nel.org>,
 davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, donald.hunter@...il.com
Subject: Re: [PATCH net] inet: bring NLM_DONE out to a separate recv() again

On Fri, 12 Apr 2024 19:38:53 +0200
Ilya Maximets <i.maximets@....org> wrote:

> On 4/12/24 19:22, Stefano Brivio wrote:
> > On Thu, 11 Apr 2024 14:01:54 -0700
> > Jakub Kicinski <kuba@...nel.org> wrote:
> >   
> >> On Thu, 11 Apr 2024 13:45:42 -0600 David Ahern wrote:  
> >>>> +	/* Don't let NLM_DONE coalesce into a message, even if it could.
> >>>> +	 * Some user space expects NLM_DONE in a separate recv().      
> >>>
> >>> that's unfortunate    
> >>
> >> Do you have an opinion on the sysfs/opt-in question?
> >> Feels to me like there shouldn't be that much user space doing raw
> >> netlink, without a library. Old crufty code usually does ioctls, right?  
> > 
> > I think so too -- if there were more (maintained) applications with
> > this issue, we would have noticed by now.  
> 
> It depends on how you define "maintained".  Most application devs
> do not test with unreleased kernels.

I haven't, either, but users started shouting: we have nowadays plenty
of distributions shipping unreleased kernels.

-- 
Stefano