netdev - RE: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CO1PR11MB50890344C93FD1007DB04EDFD6042@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Fri, 12 Apr 2024 23:38:18 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Julien Panis <jpanis@...libre.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Russell King
	<linux@...linux.org.uk>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, "John
 Fastabend" <john.fastabend@...il.com>, Sumit Semwal
	<sumit.semwal@...aro.org>, Christian König
	<christian.koenig@....com>, Simon Horman <horms@...nel.org>, Andrew Lunn
	<andrew@...n.ch>, Ratheesh Kannoth <rkannoth@...vell.com>, "Naveen
 Mamindlapalli" <naveenm@...vell.com>
CC: "danishanwar@...com" <danishanwar@...com>, "yuehaibing@...wei.com"
	<yuehaibing@...wei.com>, "rogerq@...nel.org" <rogerq@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linaro-mm-sig@...ts.linaro.org"
	<linaro-mm-sig@...ts.linaro.org>
Subject: RE: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW
 Ethernet driver



> -----Original Message-----
> From: Julien Panis <jpanis@...libre.com>
> Sent: Friday, April 12, 2024 7:02 AM
> To: Keller, Jacob E <jacob.e.keller@...el.com>; David S. Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski
> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Russell King
> <linux@...linux.org.uk>; Alexei Starovoitov <ast@...nel.org>; Daniel Borkmann
> <daniel@...earbox.net>; Jesper Dangaard Brouer <hawk@...nel.org>; John
> Fastabend <john.fastabend@...il.com>; Sumit Semwal
> <sumit.semwal@...aro.org>; Christian König <christian.koenig@....com>; Simon
> Horman <horms@...nel.org>; Andrew Lunn <andrew@...n.ch>; Ratheesh
> Kannoth <rkannoth@...vell.com>; Naveen Mamindlapalli
> <naveenm@...vell.com>
> Cc: danishanwar@...com; yuehaibing@...wei.com; rogerq@...nel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; bpf@...r.kernel.org; linux-
> media@...r.kernel.org; dri-devel@...ts.freedesktop.org; linaro-mm-
> sig@...ts.linaro.org
> Subject: Re: [PATCH net-next v8 0/3] Add minimal XDP support to TI AM65 CPSW
> Ethernet driver
> 
> On 4/10/24 01:51, Jacob Keller wrote:
> >
> > On 4/8/2024 2:38 AM, Julien Panis wrote:
> >> This patch adds XDP support to TI AM65 CPSW Ethernet driver.
> >>
> >> The following features are implemented: NETDEV_XDP_ACT_BASIC,
> >> NETDEV_XDP_ACT_REDIRECT, and NETDEV_XDP_ACT_NDO_XMIT.
> >>
> >> Zero-copy and non-linear XDP buffer supports are NOT implemented.
> >>
> >> Besides, the page pool memory model is used to get better performance.
> >>
> >> Signed-off-by: Julien Panis <jpanis@...libre.com>
> >> ---
> > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> Thank you for your review Jacob.
> I'll add your 'Reviewed-by' tag for PATCH 1/3 in next version. Unfortunately,
> I will not for PATCH 2/3 and 3/3 because there will be too many changes,
> following Jakub's comments.

Sounds good. Feel free to CC me on the next version too and I can review the new changes 😊