[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <661c056cf26d6_3e7732294f3@willemb.c.googlers.com.notmuch>
Date: Sun, 14 Apr 2024 12:33:48 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Kory Maincent <kory.maincent@...tlin.com>,
Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Richard Cochran <richardcochran@...il.com>,
Radu Pirea <radu-nicolae.pirea@....nxp.com>,
Jay Vosburgh <j.vosburgh@...il.com>,
Andy Gospodarek <andy@...yhouse.net>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Jonathan Corbet <corbet@....net>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
UNGLinuxDriver@...rochip.com,
Simon Horman <horms@...nel.org>,
Vladimir Oltean <vladimir.oltean@....com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org,
Maxime Chevallier <maxime.chevallier@...tlin.com>,
Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [PATCH net-next v10 08/13] ptp: Add phc source and helpers to
register specific PTP clock or get information
Kory Maincent wrote:
> On Wed, 10 Apr 2024 23:00:53 -0400
> Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote:
>
> > > +/**
> > > + * netdev_ptp_clock_register() - register a PTP hardware clock driver for
> > > + * a net device
> > > + *
> > > + * @info: Structure describing the new clock.
> > > + * @dev: Pointer of the net device
> > > + */
> > > +
> > > +extern struct ptp_clock *
> > > +netdev_ptp_clock_register(struct ptp_clock_info *info,
> > > + struct net_device *dev);
> >
> > No need for explicit extern?
>
> Indeed I don't think it is needed.
> I am wondering why few other functions uses it (ptp_clock_register,
> ptp_clock_event, ptp_clock_index). Do you know?
Perhaps it predates the coding style rule
Do not use the ``extern`` keyword with function declarations as this makes
lines longer and isn't strictly necessary.
Powered by blists - more mailing lists