[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240415102023.mmkkrvuh7sulelyn@skbuf>
Date: Mon, 15 Apr 2024 13:20:23 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Woojung Huh <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: microchip: drop unneeded MODULE_ALIAS
On Sun, Apr 14, 2024 at 05:49:29PM +0200, Krzysztof Kozlowski wrote:
> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> creates proper alias for SPI driver. Having another MODULE_ALIAS causes
> the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
> drivers/net/dsa/microchip/ksz_spi.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c
> index c8166fb440ab..cdc4add5f5b5 100644
> --- a/drivers/net/dsa/microchip/ksz_spi.c
> +++ b/drivers/net/dsa/microchip/ksz_spi.c
> @@ -233,13 +233,6 @@ static struct spi_driver ksz_spi_driver = {
>
> module_spi_driver(ksz_spi_driver);
>
> -MODULE_ALIAS("spi:ksz9477");
> -MODULE_ALIAS("spi:ksz9896");
> -MODULE_ALIAS("spi:ksz9897");
> -MODULE_ALIAS("spi:ksz9893");
> -MODULE_ALIAS("spi:ksz9563");
> -MODULE_ALIAS("spi:ksz8563");
> -MODULE_ALIAS("spi:ksz9567");
> MODULE_ALIAS("spi:lan937x");
The spi:lan937x alias is bogus, right? LAN937x switches are covered by
these entries in ksz_spi_ids[]:
{ "lan9370" },
{ "lan9371" },
{ "lan9372" },
{ "lan9373" },
{ "lan9374" },
> MODULE_AUTHOR("Tristram Ha <Tristram.Ha@...rochip.com>");
> MODULE_DESCRIPTION("Microchip ksz Series Switch SPI Driver");
> --
> 2.34.1
>
Powered by blists - more mailing lists