netdev - Re: [PATCH net-next] net: dsa: felix: provide own phylink MAC operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240415103453.drozvtf7tnwtpiht@skbuf>
Date: Mon, 15 Apr 2024 13:34:53 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <vladimir.oltean@....com>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	UNGLinuxDriver@...rochip.com,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Colin Foster <colin.foster@...advantage.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: felix: provide own phylink MAC
 operations

On Fri, Apr 12, 2024 at 04:15:08PM +0100, Russell King (Oracle) wrote:
> Convert felix to provide its own phylink MAC operations, thus
> avoiding the shim layer in DSA's port.c.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
> diff --git a/drivers/net/dsa/ocelot/ocelot_ext.c b/drivers/net/dsa/ocelot/ocelot_ext.c
> index 22187d831c4b..a8927dc7aca4 100644
> --- a/drivers/net/dsa/ocelot/ocelot_ext.c
> +++ b/drivers/net/dsa/ocelot/ocelot_ext.c
> @@ -96,6 +96,7 @@ static int ocelot_ext_probe(struct platform_device *pdev)
>  	ds->num_tx_queues = felix->info->num_tx_queues;
>  
>  	ds->ops = &felix_switch_ops;
> +	ds->phylink_mac_ops = &felix_phylink_mac_ops;

There are actually 2 more places which need this: felix_vsc9959.c,
seville_vsc9953.c.

>  	ds->priv = ocelot;
>  	felix->ds = ds;
>  	felix->tag_proto = DSA_TAG_PROTO_OCELOT;
> -- 
> 2.30.2
> 

---
pw-bot: cr