[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <94f86118-4e2e-460b-9f52-911835c22065@lunn.ch>
Date: Mon, 15 Apr 2024 15:48:58 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org,
tmgross@...ch.edu
Subject: Re: [PATCH net-next v1 4/4] net: phy: add Applied Micro QT2025 PHY
driver
> + let phy_id = dev.c45_read(MDIO_MMD_PMAPMD, 0xd001)?;
> + if (phy_id >> 8) & 0xff != 0xb3 {
> + return Ok(());
> + }
> +
> + dev.c45_write(MDIO_MMD_PMAPMD, 0xC300, 0x0000)?;
> + dev.c45_write(MDIO_MMD_PMAPMD, 0xC302, 0x4)?;
> + dev.c45_write(MDIO_MMD_PMAPMD, 0xC319, 0x0038)?;
> +
> + dev.c45_write(MDIO_MMD_PMAPMD, 0xC31A, 0x0098)?;
> + dev.c45_write(MDIO_MMD_PCS, 0x0026, 0x0E00)?;
> +
> + dev.c45_write(MDIO_MMD_PCS, 0x0027, 0x0893)?;
> +
> + dev.c45_write(MDIO_MMD_PCS, 0x0028, 0xA528)?;
> + dev.c45_write(MDIO_MMD_PCS, 0x0029, 0x03)?;
> + dev.c45_write(MDIO_MMD_PMAPMD, 0xC30A, 0x06E1)?;
> + dev.c45_write(MDIO_MMD_PMAPMD, 0xC300, 0x0002)?;
> + dev.c45_write(MDIO_MMD_PCS, 0xE854, 0x00C0)?;
> +
> + let mut j = 0x8000;
> + let mut a = MDIO_MMD_PCS;
> + for (i, val) in fw.data().iter().enumerate() {
> + if i == 0x4000 {
I'm assuming enumerate() does the same as Python enumerate. So `i` will
be the offset into the firmware. There is actually two different
firmware blobs in the file, and you write one into the PCS and the
second into the PHYXS?
> + a = MDIO_MMD_PHYXS;
> + j = 0x8000;
> + }
> + dev.c45_write(a, j, (*val).into())?;
Maybe my limitation with Rust. Is this writing a byte or a u16 to the
register? PHY registers are generally u16. And if it is a u16, what
about endianness?
Firmware should not be trusted. What about the case the firmware does
not have 0x4000 words in it? Is the size of the second blob known?
Also 0x4000?
It would be more normal to load firmware into the PHY during probe,
not config_init.
Andrew
Powered by blists - more mailing lists