netdev - Re: [PATCH net] udp: don't be set unconnected if only UDP cmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <661d3583a289e_c0c8294c1@willemb.c.googlers.com.notmuch>
Date: Mon, 15 Apr 2024 10:11:15 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Yick Xie <yick.xie@...il.com>, 
 willemdebruijn.kernel@...il.com, 
 willemb@...gle.com
Cc: netdev@...r.kernel.org, 
 davem@...emloft.net
Subject: Re: [PATCH net] udp: don't be set unconnected if only UDP cmsg

Yick Xie wrote:
> If "udp_cmsg_send()" returned 0 (i.e. only UDP cmsg),
> "connected" should not be set to 0. Otherwise it stops
> the connected socket from using the cached route.
> 
> Signed-off-by: Yick Xie <yick.xie@...il.com>

This either needs to target net-next, or have

Fixes: 2e8de8576343 ("udp: add gso segment cmsg")

I think it can be argued either way. This situation existed from the
start, and is true for other cmsg that don't affect routing as well.

If the impact of the route lookup is significant, it couls be argued
to be a performance bug.

I steer towards net-next. In which case it would be nice to also
move the ipc.opt branch and perhaps even exclude other common cmsgs,
such as SCM_TXTIME and SCM_TIMESTAMPING.