netdev - Re: [PATCH v7 2/5] NFSD: add write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240415110320.0291ac00@kernel.org>
Date: Mon, 15 Apr 2024 11:03:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: linux-nfs@...r.kernel.org, lorenzo.bianconi@...hat.com,
 chuck.lever@...cle.com, jlayton@...nel.org, neilb@...e.de,
 netdev@...r.kernel.org
Subject: Re: [PATCH v7 2/5] NFSD: add write_version to netlink command

On Thu, 11 Apr 2024 18:47:25 +0200 Lorenzo Bianconi wrote:
> +			attr = nla_nest_start_noflag(skb,
> +					NFSD_A_SERVER_PROTO_VERSION);

The _noflag() version is for legacy code, I think you should let 
the nest be marked appropriately.