netdev - Re: [PATCH net-next v1 0/5] add ethernet driver for Tehuti Networks TN40xx chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9506345-8245-4b3c-83a1-9425e0b37136@gmail.com>
Date: Mon, 15 Apr 2024 16:21:35 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>, netdev@...r.kernel.org
Cc: andrew@...n.ch
Subject: Re: [PATCH net-next v1 0/5] add ethernet driver for Tehuti Networks
 TN40xx chips

Hi Fujita-san,

On 4/15/2024 3:43 AM, FUJITA Tomonori wrote:
> This patchset adds a new 10G ethernet driver for Tehuti Networks
> TN40xx chips. Note in mainline, there is a driver for Tehuti Networks
> (drivers/net/ethernet/tehuti/tehuti.[hc]), which supports TN30xx
> chips.
> 
> Multiple vendors (DLink, Asus, Edimax, QNAP, etc) developed adapters
> based on TN40xx chips. Tehuti Networks went out of business but the
> drivers are still distributed with some of the hardware (and also
> available on some sites). With some changes, I try to upstream this
> driver with a new PHY driver in Rust.
> 
> The major change is replacing a PHY abstraction layer with
> PHYLIB. TN40xx chips are used with various PHY hardware (AMCC QT2025,
> TI TLK10232, Aqrate AQR105, and Marvell MV88X3120, MV88X3310, and
> MV88E2010). So the original driver has the own PHY abstraction layer
> to handle them.
> 
> I'll submit a new PHY driver for QT2025 in Rust shortly. For now, I
> enable only adapters using QT2025 PHY in the PCI ID table of this
> driver. I've tested this driver and the QT2025 PHY driver with Edimax
> EN-9320 10G adapter. In mainline, there are PHY drivers for AQR105 and
> Marvell PHYs, which could work for some TN40xx adapters with this
> driver.
> 
> The other changes are replacing the embedded firmware in a header file
> with the firmware APIs, handling dma mapping errors, removing many
> ifdef, fixing lots of style issues, etc.
> 
> To make reviewing easier, this patchset has only basic functions. Once
> merged, I'll submit features like ethtool support.

Thanks a lot for attempting to upstream support for the TN40xx chips, 
those are extremely popular 10GbE PCIe cards under USD 100. Last I 
checked the vendor driver, it was not entirely clear however whether it 
would be possible to get the various PHY firmwares included in 
linux-firmware, that is the licensing was not very specific either way 
(redistribution allowed or not).
-- 
Florian