netdev - Re: [PATCH net-next 10/10] selftests: forwarding: router

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zhzl7q3SwtPYoTHw@Laptop-X1>
Date: Mon, 15 Apr 2024 16:31:42 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
	mlxsw@...dia.com
Subject: Re: [PATCH net-next 10/10] selftests: forwarding: router_nh: Add a
 diagram

On Fri, Apr 12, 2024 at 07:03:13PM +0200, Petr Machata wrote:
> This test lacks a topology diagram, making the setup not obvious.
> Add one.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
>  .../testing/selftests/net/forwarding/router_nh.sh  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/router_nh.sh b/tools/testing/selftests/net/forwarding/router_nh.sh
> index f3a53738bdcc..92904b01eae9 100755
> --- a/tools/testing/selftests/net/forwarding/router_nh.sh
> +++ b/tools/testing/selftests/net/forwarding/router_nh.sh
> @@ -1,6 +1,20 @@
>  #!/bin/bash
>  # SPDX-License-Identifier: GPL-2.0
>  
> +# +-------------------------+  +-------------------------+
> +# | H1                      |  |                      H2 |
> +# |               $h1 +     |  |               $h2 +     |
> +# |      192.0.2.2/24 |     |  |   198.51.100.2/24 |     |
> +# |  2001:db8:1::2/64 |     |  |  2001:db8:2::2/64 |     |
> +# +-------------------|-----+  +-------------------|-----+
> +#                     |                            |
> +# +-------------------|----------------------------|-----+
> +# | R1                |                            |     |
> +# |              $rp1 +                       $rp2 +     |
> +# |      192.0.2.1/24              198.51.100.1/24       |
> +# |  2001:db8:1::1/64             2001:db8:2::1/64       |
> +# +------------------------------------------------------+
> +
>  ALL_TESTS="
>  	ping_ipv4
>  	ping_ipv6
> -- 
> 2.43.0
> 
Reviewed-by: Hangbin Liu <liuhangbin@...il.com>