netdev - Re: [PATCH net-next 5/5] selftests: drv-net: add a trivial ping test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49deeded3764fd43b9af23f2f6e1b8f4ab599910.camel@redhat.com>
Date: Mon, 15 Apr 2024 11:31:05 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, shuah@...nel.org, 
	petrm@...dia.com, linux-kselftest@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net-next 5/5] selftests: drv-net: add a trivial ping test

On Fri, 2024-04-12 at 16:37 -0700, Jakub Kicinski wrote:
> +def ping_v4(cfg) -> None:
> +    if not cfg.v4:
> +        raise KsftXfailEx()
> +
> +    cmd(f"ping -c 1 -W0.5 {cfg.ep_v4}")
> +    cmd(f"ping -c 1 -W0.5 {cfg.v4}", host=cfg.endpoint)

Very minor nit, I personally find a bit more readable:

	cfg.endpoint.cmd()

Which is already supported by the current infra, right?

With both endpoint possibly remote could be:

	cfg.ep1.cmd()
	cfg.ep2.cmd()

Thanks!

Paolo