[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240416102236.GH2320920@kernel.org>
Date: Tue, 16 Apr 2024 11:22:36 +0100
From: Simon Horman <horms@...nel.org>
To: Sai Krishna <saikrishnag@...vell.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, sgoutham@...vell.com,
gakula@...vell.com, hkelam@...vell.com, sbhatta@...vell.com
Subject: Re: [net-next PATCH] octeontx2-pf: Add ucast filter count
configurability via devlink.
On Sun, Apr 14, 2024 at 04:28:30PM +0530, Sai Krishna wrote:
> Added a devlink param to set/modify unicast filter count. Currently
> it's hardcoded with a macro.
Hi Sai,
I think it would be nice to provide a sample devlink command in
the patch description, as you did for:
2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count")
> Signed-off-by: Sai Krishna <saikrishnag@...vell.com>
...
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c
...
> +static int otx2_dl_ucast_flt_cnt_get(struct devlink *devlink, u32 id,
> + struct devlink_param_gset_ctx *ctx)
> +{
> + struct otx2_devlink *otx2_dl = devlink_priv(devlink);
> + struct otx2_nic *pfvf = otx2_dl->pfvf;
> +
> + if (!pfvf->flow_cfg) {
> + ctx->val.vu8 = 0;
> + return 0;
> + }
> +
> + ctx->val.vu8 = pfvf->flow_cfg->ucast_flt_cnt;
nit: perhaps this could be more succinctly expressed as follows
(completely untested!):
ctx->val.vu8 = pfvf->flow_cfg ? pfvf->flow_cfg->ucast_flt_cnt : 0;
> +
> + return 0;
> +}
...
Powered by blists - more mailing lists