netdev - Re: [PATCH net-next v1 4/4] net: phy: add Applied Micro QT2025 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240416.201603.1026787007638816255.fujita.tomonori@gmail.com>
Date: Tue, 16 Apr 2024 20:16:03 +0900 (JST)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: benno.lossin@...ton.me
Cc: tmgross@...ch.edu, fujita.tomonori@...il.com, netdev@...r.kernel.org,
 andrew@...n.ch, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH net-next v1 4/4] net: phy: add Applied Micro QT2025 PHY
 driver

Hi,

On Tue, 16 Apr 2024 06:58:38 +0000
Benno Lossin <benno.lossin@...ton.me> wrote:

> On 16.04.24 06:34, Trevor Gross wrote:
>> On Mon, Apr 15, 2024 at 6:47 AM FUJITA Tomonori
>> <fujita.tomonori@...il.com> wrote:
>>> +struct PhyQT2025;
>>> +
>>> +#[vtable]
>>> +impl Driver for PhyQT2025 {
>>> +    const NAME: &'static CStr = c_str!("QT2025 10Gpbs SFP+");
>> 
>> Since 1.77 we have C string literals, `c"QT2025 10Gpbs SFP+"` (woohoo)
> 
> We have our own `CStr` in the `kernel::str::CStr`, so we cannot replace
> the `c_str!` macro by the literal directly. Instead we also need to
> remove our own `CStr`. We already have an issue for that:
> https://github.com/Rust-for-Linux/linux/issues/1075

Seems that someone already started to work on this issue so I'll keep
this alone for now.