netdev - Re: [PATCH RFC net-next 2/7] netdev_features: convert NETIF_F_LLTX to priv_flag IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <654f6737-78bd-4aa7-bb35-84515d5fe3f4@intel.com>
Date: Tue, 16 Apr 2024 14:39:51 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Simon Horman <horms@...nel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Xuan Zhuo
	<xuanzhuo@...ux.alibaba.com>, Andrew Lunn <andrew@...n.ch>,
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC net-next 2/7] netdev_features: convert NETIF_F_LLTX to
 priv_flag IFF_LLTX

From: Simon Horman <horms@...nel.org>
Date: Mon, 15 Apr 2024 15:37:28 +0100

> On Fri, Apr 05, 2024 at 03:37:26PM +0200, Alexander Lobakin wrote:
>> NETIF_F_LLTX can't be changed via Ethtool and is not a feature, rather
>> an attribute, very similar to IFF_NO_QUEUE.
>> Free one netdev_features_t bit and make it a private flag.
>>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> ...
> 
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 0c198620ac93..065dd68fe97c 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -1649,6 +1649,8 @@ struct net_device_ops {
>>   * @IFF_SEE_ALL_HWTSTAMP_REQUESTS: device wants to see calls to
>>   *	ndo_hwtstamp_set() for all timestamp requests regardless of source,
>>   *	even if those aren't HWTSTAMP_SOURCE_NETDEV.
>> + @ @IFF_LLTX: device supports lockless Tx. Mainly used by logical interfaces,
> 
> Hi Alexander,
> 
> Sorry if this has already been flagged - I thought so but I can't find it now.
> 
> " @ @IFF_LLTX:" should probably be " * @IFF_LLTX:"

Sorry, yes, I messed it up.
It's an RFC though, I fixed it already for the next sub.

> 
> Flagged by ./scripts/kernel-doc -none
> 
>> + *	such as tunnels.
>>   */
>>  enum netdev_priv_flags {
>>  	IFF_802_1Q_VLAN			= 1<<0,
> 
> ...

Thanks,
Olek