netdev - Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240416072712.757d7baf@kernel.org>
Date: Tue, 16 Apr 2024 07:27:12 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dan Jurgens <danielj@...dia.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "mst@...hat.com"
 <mst@...hat.com>, "jasowang@...hat.com" <jasowang@...hat.com>,
 "xuanzhuo@...ux.alibaba.com" <xuanzhuo@...ux.alibaba.com>,
 "virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
 "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, Jiri Pirko
 <jiri@...dia.com>
Subject: Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX
 coalesce

On Tue, 16 Apr 2024 03:15:34 +0000 Dan Jurgens wrote:
> Which version? It compiles for me with:
> $ clang -v
> clang version 15.0.7 (Fedora 15.0.7-2.fc37)

clang version 17.0.6 (Fedora 17.0.6-2.fc39)

allmodconfig

The combination of UNIQUE() goto and guard seems to make it unhappy:

../drivers/net/virtio_net.c:3613:3: error: cannot jump from this goto
statement to its label 3613 |                 goto out; |                 ^
../drivers/net/virtio_net.c:3615:2: note: jump bypasses initialization of variable with __attribute__((cleanup))
 3615 |         guard(spinlock)(&rq->intr_coal_lock);
      |         ^
../include/linux/cleanup.h:164:15: note: expanded from macro 'guard'
  164 |         CLASS(_name, __UNIQUE_ID(guard))
      |                      ^
../include/linux/compiler.h:189:29: note: expanded from macro '__UNIQUE_ID'
  189 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
      |                             ^
./../include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
   84 | #define __PASTE(a,b) ___PASTE(a,b)
      |                      ^
./../include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
   83 | #define ___PASTE(a,b) a##b
      |                       ^
<scratch space>:18:1: note: expanded from here
   18 | __UNIQUE_ID_guard2044
      | ^
1 error generated.