netdev - Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel elements from ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240416123212.nrgpuix3dhkmfbzq@joelS2.panther.com>
Date: Tue, 16 Apr 2024 14:32:12 +0200
From: Joel Granados <j.granados@...sung.com>
To: Paolo Abeni <pabeni@...hat.com>
CC: Kuniyuki Iwashima <kuniyu@...zon.com>,
	<devnull+j.granados.samsung.com@...nel.org>, <Dai.Ngo@...cle.com>,
	<alex.aring@...il.com>, <alibuda@...ux.alibaba.com>,
	<allison.henderson@...cle.com>, <anna@...nel.org>, <bridge@...ts.linux.dev>,
	<chuck.lever@...cle.com>, <coreteam@...filter.org>, <courmisch@...il.com>,
	<davem@...emloft.net>, <dccp@...r.kernel.org>, <dhowells@...hat.com>,
	<dsahern@...nel.org>, <edumazet@...gle.com>, <fw@...len.de>,
	<geliang@...nel.org>, <guwen@...ux.alibaba.com>,
	<herbert@...dor.apana.org.au>, <horms@...ge.net.au>, <ja@....bg>,
	<jaka@...ux.ibm.com>, <jlayton@...nel.org>, <jmaloy@...hat.com>,
	<jreuter@...na.de>, <kadlec@...filter.org>, <keescook@...omium.org>,
	<kolga@...app.com>, <kuba@...nel.org>, <linux-afs@...ts.infradead.org>,
	<linux-hams@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-nfs@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<linux-s390@...r.kernel.org>, <linux-sctp@...r.kernel.org>,
	<linux-wpan@...r.kernel.org>, <linux-x25@...r.kernel.org>,
	<lucien.xin@...il.com>, <lvs-devel@...r.kernel.org>,
	<marc.dionne@...istor.com>, <marcelo.leitner@...il.com>,
	<martineau@...nel.org>, <matttbe@...nel.org>, <mcgrof@...nel.org>,
	<miquel.raynal@...tlin.com>, <mptcp@...ts.linux.dev>, <ms@....tdt.de>,
	<neilb@...e.de>, <netdev@...r.kernel.org>,
	<netfilter-devel@...r.kernel.org>, <pablo@...filter.org>,
	<ralf@...ux-mips.org>, <razor@...ckwall.org>, <rds-devel@....oracle.com>,
	<roopa@...dia.com>, <stefan@...enfreihafen.org>,
	<steffen.klassert@...unet.com>, <tipc-discussion@...ts.sourceforge.net>,
	<tom@...pey.com>, <tonylu@...ux.alibaba.com>,
	<trond.myklebust@...merspace.com>, <wenjia@...ux.ibm.com>,
	<ying.xue@...driver.com>
Subject: Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel
 elements from ctl_table array

On Tue, Apr 16, 2024 at 10:18:42AM +0200, Paolo Abeni wrote:
> On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote:
> > From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@...nel.org>
> > Date: Fri, 12 Apr 2024 16:48:29 +0200
> > > From: Joel Granados <j.granados@...sung.com>
...
> > >  net/rxrpc/sysctl.c                  | 1 -
> > >  net/sctp/sysctl.c                   | 6 +-----
> > >  net/smc/smc_sysctl.c                | 1 -
> > >  net/sunrpc/sysctl.c                 | 1 -
> > >  net/sunrpc/xprtrdma/svc_rdma.c      | 1 -
> > >  net/sunrpc/xprtrdma/transport.c     | 1 -
> > >  net/sunrpc/xprtsock.c               | 1 -
> > >  net/tipc/sysctl.c                   | 1 -
> > >  net/unix/sysctl_net_unix.c          | 1 -
> > >  net/x25/sysctl_net_x25.c            | 1 -
> > >  net/xfrm/xfrm_sysctl.c              | 5 +----
> > >  35 files changed, 20 insertions(+), 81 deletions(-)
> > 
> > You may want to split patch based on subsystem or the type of changes
> > to make review easier.
> 
> I agree with Kuniyuki. I think the x25 chunks can me moved in the last
> patch, and at least sunrpc and rds could go in separate patches,
> possibly even xfrm and smc.

No problem. I'll put x25 and ax.25 patches together into one commit.
Thx

Best

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)