netdev - Re: [PATCH net-next v4 3/6] rstreason: prepare for active reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoA+vtTKLQGMrbS5Y0-Wmq4M0BAzojWKrT7KA6Ju_Eh0bw@mail.gmail.com>
Date: Tue, 16 Apr 2024 16:27:06 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: edumazet@...gle.com, dsahern@...nel.org, matttbe@...nel.org, 
	martineau@...nel.org, geliang@...nel.org, kuba@...nel.org, 
	davem@...emloft.net, rostedt@...dmis.org, mhiramat@...nel.org, 
	mathieu.desnoyers@...icios.com, atenart@...nel.org, mptcp@...ts.linux.dev, 
	netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v4 3/6] rstreason: prepare for active reset

On Tue, Apr 16, 2024 at 4:01 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On Thu, 2024-04-11 at 19:56 +0800, Jason Xing wrote:
> > diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
> > index 744c87b6d5a4..ba0a252c113f 100644
> > --- a/net/mptcp/subflow.c
> > +++ b/net/mptcp/subflow.c
> > @@ -412,7 +412,7 @@ void mptcp_subflow_reset(struct sock *ssk)
> >       /* must hold: tcp_done() could drop last reference on parent */
> >       sock_hold(sk);
> >
> > -     tcp_send_active_reset(ssk, GFP_ATOMIC);
> > +     tcp_send_active_reset(ssk, GFP_ATOMIC, SK_RST_REASON_NOT_SPECIFIED);
>
> I'm sorry for the late feedback.

Thanks for the review, Paolo :)

>
> Some of the caller can set subflow->reset_reason, so probably something
> alike the following:
>
>         tcp_send_active_reset(ssk, GFP_ATOMIC,
>                               subflow->reset_reason?: SK_RST_REASON_NOT_SPECIFIED);
>
>
> would work - with an helper even better.
>
> Could be a follow-up patch.

I see. I can add this as a separate patch when I submit soon with your
suggested-by tag because I also want to make every patch clean and
simple.

Thanks,
Jason

>
> Thanks,
>
> Paolo
>