netdev - Re: [PATCH net-next 01/12] selftests: netfilter: conntrack_icmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce433aee-b478-4fcf-b8e1-3b38bfca795a@kernel.org>
Date: Tue, 16 Apr 2024 10:44:13 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Cc: Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 netfilter-devel@...r.kernel.org, pablo@...filter.org
Subject: Re: [PATCH net-next 01/12] selftests: netfilter:
 conntrack_icmp_related.sh: move to lib.sh infra

Hi Florian,

On 15/04/2024 00:57, Florian Westphal wrote:
> Only relevant change is that netns names have random suffix names,
> i.e. its safe to run this in parallel with other tests.

According to the patch title and description, it looks like something is
missing from the diff below where on the 'config' file is modified, no?

Same for patch 2/12 where we have the opposite modification.

(BTW, it is good to see all the shellcheck cleanups, my text editor will
show fewer warnings :) )

> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  tools/testing/selftests/net/netfilter/config | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config
> index 9df6a9f11384..a34c284242ec 100644
> --- a/tools/testing/selftests/net/netfilter/config
> +++ b/tools/testing/selftests/net/netfilter/config
> @@ -2,6 +2,8 @@ CONFIG_AUDIT=y
>  CONFIG_BRIDGE_EBT_BROUTE=m
>  CONFIG_BRIDGE_EBT_REDIRECT=m
>  CONFIG_BRIDGE_NETFILTER=m
> +CONFIG_NF_CONNTRACK=m
> +CONFIG_NF_CT_NETLINK=m
>  CONFIG_IP_NF_MATCH_RPFILTER=m
>  CONFIG_IP6_NF_MATCH_RPFILTER=m
>  CONFIG_IP_SCTP=m

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.