netdev - Re: [PATCH net-next v6 02/11] net/smc: introduce loopback-ism for SMC intra-OS shortcut

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c1ef62610506524763bc2d4f673279e0cb624b6.camel@linux.ibm.com>
Date: Wed, 17 Apr 2024 12:20:06 +0200
From: Gerd Bayer <gbayer@...ux.ibm.com>
To: Wen Gu <guwen@...ux.alibaba.com>, wintera@...ux.ibm.com,
        twinkler@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com,
        agordeev@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, wenjia@...ux.ibm.com,
        jaka@...ux.ibm.com
Cc: borntraeger@...ux.ibm.com, svens@...ux.ibm.com, alibuda@...ux.alibaba.com,
        tonylu@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 02/11] net/smc: introduce loopback-ism for
 SMC intra-OS shortcut

On Sun, 2024-04-14 at 12:02 +0800, Wen Gu wrote:
> This introduces a kind of Emulated-ISM device named loopback-ism for
> SMCv2.1. The loopback-ism device is currently exclusive for SMC
> usage, and aims to provide an SMC shortcut for sockets within the
> same kernel, leading to improved intra-OS traffic performance.
> Configuration of this feature is managed through the config SMC_LO.
> 
> Signed-off-by: Wen Gu <guwen@...ux.alibaba.com>
> ---
>  net/smc/Kconfig        |  13 ++++
>  net/smc/Makefile       |   1 +
>  net/smc/af_smc.c       |  12 +++-
>  net/smc/smc_loopback.c | 156
> +++++++++++++++++++++++++++++++++++++++++
>  net/smc/smc_loopback.h |  43 ++++++++++++
>  5 files changed, 224 insertions(+), 1 deletion(-)
>  create mode 100644 net/smc/smc_loopback.c
>  create mode 100644 net/smc/smc_loopback.h
> 

Thanks Wen Gu,

this looks good to me now. A W=1 compile-test of the whole series with
SMC_LO undefined showed that there were no additional unresolved
symbols introduced.

Feel free to add my
Reviewed-by: Gerd Bayer <gbayer@...ux.ibm.com>