netdev - Re: [PATCH net-next v6 03/10] net: create a dummy net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebe80c29-4884-488d-ab83-c020f9c3bc81@intel.com>
Date: Wed, 17 Apr 2024 12:51:12 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Breno Leitao <leitao@...ian.org>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<elder@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-mediatek@...ts.infradead.org>, <nbd@....name>,
	<sean.wang@...iatek.com>, <Mark-MC.Lee@...iatek.com>, <lorenzo@...nel.org>,
	<taras.chornyi@...ision.eu>, <ath11k@...ts.infradead.org>,
	<ath10k@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
	<geomatsi@...il.com>, <kvalo@...nel.org>, <quic_jjohnson@...cinc.com>,
	<leon@...nel.org>, <dennis.dalessandro@...nelisnetworks.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<bpf@...r.kernel.org>, <idosch@...sch.org>, Ido Schimmel <idosch@...dia.com>,
	Jiri Pirko <jiri@...nulli.us>, Simon Horman <horms@...nel.org>, "Daniel
 Borkmann" <daniel@...earbox.net>, Sebastian Andrzej Siewior
	<bigeasy@...utronix.de>
Subject: Re: [PATCH net-next v6 03/10] net: create a dummy net_device
 allocator

From: Jakub Kicinski <kuba@...nel.org>
Date: Fri, 12 Apr 2024 19:16:26 -0700

> On Thu, 11 Apr 2024 06:59:27 -0700 Breno Leitao wrote:
>> +/**
>> + * alloc_netdev_dummy - Allocate and initialize a dummy net device.
>> + * @sizeof_priv: size of private data to allocate space for
>> + */
>> +struct net_device *alloc_netdev_dummy(int sizeof_priv)
> 
> Sorry, one more round :)
> 
> We started using -Wall for kdoc (./scripts/kernel-doc -Wall $files)
> recently and it now complains about missing return values...

Just FYI: kdoc accepts only this pattern:

 * @last_param: blah
 *
 * Return: blah

NOT

 * Returns: blah

neither

 * Returns blah

Only "Return: blah" with a blank newline between it and the last
argument (or extended description).

Thanks,
Olek