netdev - Re: [PATCH net-next v2 3/3] tools/net/ynl: Add multi message support to ynl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2r0fahpp4.fsf@gmail.com>
Date: Fri, 12 Apr 2024 10:53:43 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Paolo Abeni <pabeni@...hat.com>,  Jiri
 Pirko <jiri@...nulli.us>,  Jacob Keller <jacob.e.keller@...el.com>,  Pablo
 Neira Ayuso <pablo@...filter.org>,  Jozsef Kadlecsik
 <kadlec@...filter.org>,  netfilter-devel@...r.kernel.org,
  coreteam@...filter.org,  donald.hunter@...hat.com
Subject: Re: [PATCH net-next v2 3/3] tools/net/ynl: Add multi message
 support to ynl

Jakub Kicinski <kuba@...nel.org> writes:

> On Wed, 10 Apr 2024 23:11:08 +0100 Donald Hunter wrote:
>> -    def do(self, method, vals, flags=None):
>> +    def _op(self, method, vals, flags):
>> +        ops = [(method, vals, flags)]
>> +        return self._ops(ops)[0]
>> +
>> +    def do(self, method, vals, flags=[]):
>>          return self._op(method, vals, flags)
>
> Commenting here instead of on my own series but there are already tests
> using dump=True in net-next:
>
> tools/testing/selftests/drivers/net/stats.py:    stats = netfam.qstats_get({}, dump=True)
> tools/testing/selftests/net/nl_netdev.py:        devs = nf.dev_get({}, dump=True)
>
> "flags=[Netlink.NLM_F_DUMP]" is going to be a lot less convenient 
> to write :( Maybe we can keep support for both?

Good catch, I overlooked the generated methods. I'll make sure to add it
back in.