netdev - [PATCH] m_ife: Remove unused value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20240417170722.28084-1-maks.mishinFZ@gmail.com>
Date: Wed, 17 Apr 2024 20:07:22 +0300
From: Maks Mishin <maks.mishinfz@...il.com>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: Maks Mishin <maks.mishinFZ@...il.com>,
	netdev@...r.kernel.org
Subject: [PATCH] m_ife: Remove unused value

The variable `has_optional` do not used after set the value.

Signed-off-by: Maks Mishin <maks.mishinFZ@...il.com>
---
 tc/m_ife.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/tc/m_ife.c b/tc/m_ife.c
index 162607ce..f8a5e427 100644
--- a/tc/m_ife.c
+++ b/tc/m_ife.c
@@ -219,7 +219,6 @@ static int print_ife(struct action_util *au, FILE *f, struct rtattr *arg)
 	__u32 mmark = 0;
 	__u16 mtcindex = 0;
 	__u32 mprio = 0;
-	int has_optional = 0;
 	SPRINT_BUF(b2);
 
 	print_string(PRINT_ANY, "kind", "%s ", "ife");
@@ -240,13 +239,9 @@ static int print_ife(struct action_util *au, FILE *f, struct rtattr *arg)
 
 	if (tb[TCA_IFE_TYPE]) {
 		ife_type = rta_getattr_u16(tb[TCA_IFE_TYPE]);
-		has_optional = 1;
 		print_0xhex(PRINT_ANY, "type", "type %#llX ", ife_type);
 	}
 
-	if (has_optional)
-		print_string(PRINT_FP, NULL, "%s\t", _SL_);
-
 	if (tb[TCA_IFE_METALST]) {
 		struct rtattr *metalist[IFE_META_MAX + 1];
 		int len = 0;
@@ -290,21 +285,17 @@ static int print_ife(struct action_util *au, FILE *f, struct rtattr *arg)
 
 	}
 
-	if (tb[TCA_IFE_DMAC]) {
-		has_optional = 1;
+	if (tb[TCA_IFE_DMAC])
 		print_string(PRINT_ANY, "dst", "dst %s ",
 			     ll_addr_n2a(RTA_DATA(tb[TCA_IFE_DMAC]),
 					 RTA_PAYLOAD(tb[TCA_IFE_DMAC]), 0, b2,
 					 sizeof(b2)));
-	}
 
-	if (tb[TCA_IFE_SMAC]) {
-		has_optional = 1;
+	if (tb[TCA_IFE_SMAC])
 		print_string(PRINT_ANY, "src", "src %s ",
 			     ll_addr_n2a(RTA_DATA(tb[TCA_IFE_SMAC]),
 					 RTA_PAYLOAD(tb[TCA_IFE_SMAC]), 0, b2,
 					 sizeof(b2)));
-	}
 
 	print_nl();
 	print_uint(PRINT_ANY, "index", "\t index %u", p->index);
-- 
2.30.2