netdev - Re: [PATCH net-next] net: dsa: bcm_sf2: provide own phylink MAC operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88dda23e-3aa8-43c1-879c-06afc8462938@broadcom.com>
Date: Tue, 16 Apr 2024 20:13:27 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>,
 Florian Fainelli <f.fainelli@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: bcm_sf2: provide own phylink MAC
 operations



On 4/16/2024 11:16 AM, Russell King (Oracle) wrote:
> On Tue, Apr 16, 2024 at 10:44:38AM -0700, Florian Fainelli wrote:
>> On 4/16/24 03:19, Russell King (Oracle) wrote:
>>> Convert bcm_sf2 to provide its own phylink MAC operations, thus
>>> avoiding the shim layer in DSA's port.c
>>>
>>> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
>>
>> Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>
>> Tested-by: Florian Fainelli <florian.fainelli@...adcom.com>
> 
> Great, thanks for testing.
> 
> (Unrelated to this patch... so please don't delay applying based on
> ongoing discussion!)
> 
> The other Broadcom driver, b53, isn't going to be as simple - I believe
> it uses a mixture of the .adjust_link method for shared ports, and
> .phylink_mac_* for user ports. That makes it very awkward now, given
> the check that was added (and suggested by Vladimir) to check for the
> legacy methods if dsa_switch's .phylink_mac_ops is populated.
> 
> Is there any scope for converting b53 to use only phylink methods for
> everything, thus eliminating the .adjust_link callback?

It is on the TODO list for sure, and there might be a window later this 
week to actually work on removing the adjust_link callback once and for all.
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)