lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20240417153007.4bca29aa@hermes.local>
Date: Wed, 17 Apr 2024 15:30:07 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Maks Mishin <maks.mishinfz@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] m_ife: Remove unused value

On Wed, 17 Apr 2024 20:08:55 +0300
Maks Mishin <maks.mishinfz@...il.com> wrote:

> >                 ife_type = rta_getattr_u16(tb[TCA_IFE_TYPE]);
> > -               has_optional = 1;
> >                 print_0xhex(PRINT_ANY, "type", "type %#llX ", ife_type);
> >         }
> >
> > -       if (has_optional)
> > -               print_string(PRINT_FP, NULL, "%s\t", _SL_);
> > -

It is used. The printout would change with your patch. It would cause more
things to be one line.

The lower two has_optional parts have no effect and could be removed.

But before removing them, it would to look back in older versions
of iproute2 before JSON was introduced to see if this was something
that got mangled then.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ