netdev - Re: [patch net-next v3 6/6] selftests: virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ttjzawhd.fsf@nvidia.com>
Date: Thu, 18 Apr 2024 10:39:49 +0200
From: Petr Machata <petrm@...dia.com>
To: Jiri Pirko <jiri@...nulli.us>
CC: <netdev@...r.kernel.org>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <parav@...dia.com>,
	<mst@...hat.com>, <jasowang@...hat.com>, <xuanzhuo@...ux.alibaba.com>,
	<shuah@...nel.org>, <petrm@...dia.com>, <liuhangbin@...il.com>,
	<vladimir.oltean@....com>, <bpoirier@...dia.com>, <idosch@...dia.com>,
	<virtualization@...ts.linux.dev>
Subject: Re: [patch net-next v3 6/6] selftests: virtio_net: add initial tests


Jiri Pirko <jiri@...nulli.us> writes:

> From: Jiri Pirko <jiri@...dia.com>
>
> Introduce initial tests for virtio_net driver. Focus on feature testing
> leveraging previously introduced debugfs feature filtering
> infrastructure. Add very basic ping and F_MAC feature tests.
>
> To run this, do:
> $ make -C tools/testing/selftests/ TARGETS=drivers/net/virtio_net/ run_tests
>
> Run it on a system with 2 virtio_net devices connected back-to-back
> on the hypervisor.
>
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

> +h2_destroy()
> +{
> +	simple_if_fini $h2 $H2_IPV4/24 $H2_IPV6/64
> +}
> +
> +initial_ping_test()
> +{
> +	cleanup

All these cleanup() calls will end up possibly triggering
PAUSE_ON_CLEANUP. Not sure that's intended.

> +	setup_prepare
> +	ping_test $h1 $H2_IPV4 " simple"
> +}

Other than this nit, LGTM.

Reviewed-by: Petr Machata <petrm@...dia.com>