netdev - Re: [PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCN7xL-18xL04KCZUYfegBH0vWa8i5EEa8UkhoedbmrpOqyWg@mail.gmail.com>
Date: Thu, 18 Apr 2024 05:25:43 -0500
From: Adam Ford <aford173@...il.com>
To: Flavio Suligoi <f.suligoi@...m.it>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, 
	Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

On Thu, Apr 18, 2024 at 4:12 AM Flavio Suligoi <f.suligoi@...m.it> wrote:
>
> Strict priority for the tx scheduler is by default in Linux driver, so the
> tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
> platform: Delete a redundant condition branch").
>
> This property is still in use in the following DT (and it will be removed
> in a separate patch series):
>
> - arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
> - arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> - arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> - arch/arm64/boot/dts/qcom/sa8540p-ride.dts
> - arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>
> There is no problem if that property is still used in the DTs above,
> since, as seen above, it is a default property of the driver.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@...m.it>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>

Acked-by:  Adam Ford <aford173@...il.com>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
>  1 file changed, 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 15073627c53a..21cc27e75f50 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -328,9 +328,6 @@ properties:
>        snps,tx-sched-dwrr:
>          type: boolean
>          description: Deficit Weighted Round Robin
> -      snps,tx-sched-sp:
> -        type: boolean
> -        description: Strict priority
>      allOf:
>        - if:
>            required:
> @@ -339,7 +336,6 @@ properties:
>            properties:
>              snps,tx-sched-wfq: false
>              snps,tx-sched-dwrr: false
> -            snps,tx-sched-sp: false
>        - if:
>            required:
>              - snps,tx-sched-wfq
> @@ -347,7 +343,6 @@ properties:
>            properties:
>              snps,tx-sched-wrr: false
>              snps,tx-sched-dwrr: false
> -            snps,tx-sched-sp: false
>        - if:
>            required:
>              - snps,tx-sched-dwrr
> @@ -355,15 +350,6 @@ properties:
>            properties:
>              snps,tx-sched-wrr: false
>              snps,tx-sched-wfq: false
> -            snps,tx-sched-sp: false
> -      - if:
> -          required:
> -            - snps,tx-sched-sp
> -        then:
> -          properties:
> -            snps,tx-sched-wrr: false
> -            snps,tx-sched-wfq: false
> -            snps,tx-sched-dwrr: false
>      patternProperties:
>        "^queue[0-9]$":
>          description: Each subnode represents a queue.
> --
> 2.34.1
>
>