netdev - Re: [PATCH v2 net-next 11/14] net_sched: sch_hfsc: implement lockless accesses to q->defcls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240418150444.GF3975545@kernel.org>
Date: Thu, 18 Apr 2024 16:04:44 +0100
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Toke Høiland-Jørgensen <toke@...hat.com>,
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 11/14] net_sched: sch_hfsc: implement
 lockless accesses to q->defcls

On Thu, Apr 18, 2024 at 07:32:45AM +0000, Eric Dumazet wrote:
> Instead of relying on RTNL, hfsc_dump_qdisc() can use READ_ONCE()
> annotation, paired with WRITE_ONCE() one in hfsc_change_qdisc().
> 
> Use READ_ONCE(q->defcls) in hfsc_classify() to
> no longer acquire qdisc lock from hfsc_change_qdisc().
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Simon Horman <horms@...nel.org>