netdev - Re: [PATCH net v2 2/3] mlxsw: core_env: Fix driver initialization with old firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240418175534.GJ3975545@kernel.org>
Date: Thu, 18 Apr 2024 18:55:34 +0100
From: Simon Horman <horms@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
	mlxsw@...dia.com, Tim 'mithro' Ansell <me@...h.ro>
Subject: Re: [PATCH net v2 2/3] mlxsw: core_env: Fix driver initialization
 with old firmware

On Thu, Apr 18, 2024 at 03:46:07PM +0200, Petr Machata wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> The driver queries the Management Capabilities Mask (MCAM) register
> during initialization to understand if it can read up to 128 bytes from
> transceiver modules.
> 
> However, not all firmware versions support this register, leading to the
> driver failing to load.
> 
> Fix by treating an error in the register query as an indication that the
> feature is not supported.
> 
> Fixes: 1f4aea1f72da ("mlxsw: core_env: Read transceiver module EEPROM in 128 bytes chunks")
> Cc: Simon Horman <horms@...nel.org>
> Reported-by: Tim 'mithro' Ansell <me@...h.ro>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Petr Machata <petrm@...dia.com>
> ---
> 
> Notes:
>     v2:
>     - Make mlxsw_env_max_module_eeprom_len_query() void

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>