netdev - Re: [PATCH net v2] net: bcmasp: fix memory leak when bringing down interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240418183325.GM3975545@kernel.org>
Date: Thu, 18 Apr 2024 19:33:25 +0100
From: Simon Horman <horms@...nel.org>
To: Justin Chen <justin.chen@...adcom.com>
Cc: netdev@...r.kernel.org,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"open list:BROADCOM ASP 2.0 ETHERNET DRIVER" <bcm-kernel-feedback-list@...adcom.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] net: bcmasp: fix memory leak when bringing down
 interface

On Thu, Apr 18, 2024 at 11:05:41AM -0700, Justin Chen wrote:
> When bringing down the TX rings we flush the rings but forget to
> reclaimed the flushed packets. This leads to a memory leak since we
> do not free the dma mapped buffers. This also leads to tx control
> block corruption when bringing down the interface for power
> management.
> 
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
> Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>

Reviewed-by: Simon Horman <horms@...nel.org>