netdev - Re: [PATCH net] net: b44: set pause params only when interface is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a38a8279-1e06-4e9f-894e-c7a3cda15ae6@lunn.ch>
Date: Thu, 18 Apr 2024 22:44:24 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Michael Chan <michael.chan@...adcom.com>
Cc: Peter Münster <pm@...n.net>, netdev@...r.kernel.org,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net] net: b44: set pause params only when interface is up

On Thu, Apr 18, 2024 at 01:40:00PM -0700, Michael Chan wrote:
> On Thu, Apr 18, 2024 at 1:27 PM Peter Münster <pm@...n.net> wrote:
> >
> > On Thu, Apr 18 2024, Andrew Lunn wrote:
> >
> > > Please include a Fixed: tag indicating when the problem was added.
> >
> > Hi Andrew,
> >
> > I’m sorry, I don’t know, when the problem was added. I only know, that
> > there was no problem with OpenWrt < 23.X. But I don’t know why. Perhaps
> > the behaviour of netifd has changed from 22.X to 23.X.
> >
> > So I guess, that the problem is there since the creation of
> > b44_set_pauseparam(), but it has never been triggered before.
> >
> > So what should I do please with the Fixed: tag?
> >
> 
> It looks like this dates back to the beginning of git.  So I guess it should be:

Yes, i came to the same conclusion.

> Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)

Agreed.

	Andrew