[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240419064552.5dbe33e6@kernel.org>
Date: Fri, 19 Apr 2024 06:45:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Paolo Abeni
<pabeni@...hat.com>, netdev@...r.kernel.org, David Ahern
<dsahern@...nel.org>, eric.dumazet@...il.com, Andreas Roeseler
<andreas.a.roeseler@...il.com>
Subject: Re: [PATCH net] icmp: prevent possible NULL dereferences from
icmp_build_probe()
On Fri, 19 Apr 2024 10:53:32 +0000 Eric Dumazet wrote:
> + in6_dev = __in6_dev_get(dev);
> + if (in6_dev && !list_empty(&in6_dev->addr_list))
There's got to be some conditional include somewhere because this seems
to break cut-down builds (presumably IPv6=n):
net/ipv4/icmp.c: In function ‘icmp_build_probe’:
net/ipv4/icmp.c:1125:19: error: implicit declaration of function ‘__in6_dev_get’; did you mean ‘in_dev_get’? [-Werror=implicit-function-declaration]
1125 | in6_dev = __in6_dev_get(dev);
| ^~~~~~~~~~~~~
| in_dev_get
net/ipv4/icmp.c:1125:17: error: assignment to ‘struct inet6_dev *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
1125 | in6_dev = __in6_dev_get(dev);
| ^
--
pw-bot: cr
Powered by blists - more mailing lists