netdev - Re: [PATCH net v2] net: b44: set pause params only when interface is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3615d058-13c7-4e51-9299-e994ca9c13f3@lunn.ch>
Date: Fri, 19 Apr 2024 21:06:22 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Peter Münster <pm@...n.net>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org,
	Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH net v2] net: b44: set pause params only when interface is
 up

On Fri, Apr 19, 2024 at 06:17:47PM +0200, Peter Münster wrote:
> Hi,
> 
> This patch fixes a kernel panic when using netifd.
> Could you please apply it also to linux-5.15.y at least?
> 
> TIA and kind regards,
> -- 
>            Peter

Hi Peter

This is better, but still has some process issues.

> b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
> unconditionally, but b44::rx_buffers is only valid when the
> device is up (they get allocated in b44_open(), and deallocated
> again in b44_close()), any other time these is just a NULL pointers.
> 
> So if you try to change the pause params while the network interface
> is disabled/administratively down, everything explodes (which likely
> netifd tries to do).
> 
> Link: https://github.com/openwrt/openwrt/issues/13789
> Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)

Cc: stable@...r.kernel.org

needs to go here. Your patch will first get applied to the next -rc
release. Once it is published there, any patches with this tag are
automatically added to the list for backporting to stable. That will
include all long term stable branches, so there is no need to request
specifically linux-5.15.

There is some documentation about this here:

https://www.kernel.org/doc/Documentation/process/stable-kernel-rules.rst

> Reported-by: Peter Münster <pm@...n.net>
> Suggested-by: Jonas Gorski <jonas.gorski@...il.com>
> Signed-off-by: Vaclav Svoboda <svoboda@...g.cz>
> Tested-by: Peter Münster <pm@...n.net>
> Signed-off-by: Peter Münster <pm@...n.net>
> ---

Anything above the --- gets merged as the commit message. Anything
below it and the patch proper gets discarded. This is where you can
add comments for Maintainers etc. For this patch, you don't actually
need any such comments.

I often say to mainline newbies: The code is easy, the hard bit is the
processes.

	Andrew