netdev - Re: [PATCH net v3] net: b44: set pause params only when interface is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <876ff4fa-1744-4929-9da8-8a10016c2f30@lunn.ch>
Date: Fri, 19 Apr 2024 23:14:10 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Peter Münster <pm@...n.net>
Cc: netdev@...r.kernel.org, Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH net v3] net: b44: set pause params only when interface is
 up

On Fri, Apr 19, 2024 at 10:44:28PM +0200, Peter Münster wrote:
> Hi,
> 
> This patch fixes a kernel panic when using netifd.
> 
> Kind regards,
> -- 
>            Peter

Still above the --- . Don't use attachments.

The best way to send patches is

git format-patch

followed by

git send email

https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format

Alternatively, look at b4:

https://b4.docs.kernel.org/en/latest/contributor/prep.html

Interestingly, patchwork does seemed to of extracted the patch:

https://patchwork.kernel.org/project/netdevbpf/patch/87o7a5yteb.fsf@a16n.net/

So it could be the patch can be applied as it is. Lets see what Jakub
says.

Anyway:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

We are picky about things like this because there are a lot of patches
flying around, and we need to be efficient at applying them. So we
want patches in a specific format. It takes a little bit of time to
learn to do it correct, but once you use the tools correctly it
becomes simple as a developer and efficient for those receiving the
patches.

     Andrew