netdev - Re: [PATCH net-next] tcp: do not export tcp_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240419235716.32952-1-kuniyu@amazon.com>
Date: Fri, 19 Apr 2024 16:57:16 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <kuba@...nel.org>,
	<kuniyu@...zon.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next] tcp: do not export tcp_twsk_purge()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 19 Apr 2024 07:19:42 +0000
> After commit 1eeb50435739 ("tcp/dccp: do not care about
> families in inet_twsk_purge()") tcp_twsk_purge() is
> no longer potentially called from a module.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>


> ---
>  net/ipv4/tcp_minisocks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
> index f53c7ada2ace4219917e75f806f39a00d5ab0123..146c061145b4602082d149e65f8e6bbcf4bd311b 100644
> --- a/net/ipv4/tcp_minisocks.c
> +++ b/net/ipv4/tcp_minisocks.c
> @@ -403,7 +403,6 @@ void tcp_twsk_purge(struct list_head *net_exit_list)
>  		}
>  	}
>  }
> -EXPORT_SYMBOL_GPL(tcp_twsk_purge);
>  
>  /* Warning : This function is called without sk_listener being locked.
>   * Be sure to read socket fields once, as their value could change under us.
> -- 
> 2.44.0.769.g3c40516874-goog
>