netdev - Re: [PATCH net-next v3 1/3] net: rps: protect last_qtail with rps_input_queue_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+m=mt1w=ooOzh71sfTjTaTDZqB2eff_ki5DGwrFU3kGQ@mail.gmail.com>
Date: Fri, 19 Apr 2024 07:57:26 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: kuba@...nel.org, pabeni@...hat.com, davem@...emloft.net, horms@...nel.org, 
	netdev@...r.kernel.org, Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v3 1/3] net: rps: protect last_qtail with
 rps_input_queue_tail_save() helper

On Thu, Apr 18, 2024 at 9:36 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> From: Jason Xing <kernelxing@...cent.com>
>
> Removing one unnecessary reader protection and add another writer
> protection to finish the locklessly proctection job.
>
> Note: the removed READ_ONCE() is not needed because we only have to protect
> the locklessly reader in the different context (rps_may_expire_flow()).
>
> Signed-off-by: Jason Xing <kernelxing@...cent.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>