netdev - Re: [PATCHv1 next] ptp: update gettimex64 to provide ts optionally in mono-raw base.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZiIPIKM1rH7J-Pok@hoboy.vegasvil.org>
Date: Thu, 18 Apr 2024 23:28:48 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Mahesh Bandewar <maheshb@...gle.com>, Netdev <netdev@...r.kernel.org>,
	Linux <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>, Arnd Bergmann <arnd@...db.de>,
	Sagi Maimon <maimon.sagi@...il.com>,
	Jonathan Corbet <corbet@....net>, John Stultz <jstultz@...gle.com>,
	Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCHv1 next] ptp: update gettimex64 to provide ts optionally
 in mono-raw base.

On Wed, Apr 17, 2024 at 06:24:45PM -0700, Jakub Kicinski wrote:
> On Tue, 16 Apr 2024 14:59:42 -0700 Mahesh Bandewar wrote:
> >  		if (extoff->n_samples > PTP_MAX_SAMPLES
> > -		    || extoff->rsv[0] || extoff->rsv[1] || extoff->rsv[2]) {
> > +		    || extoff->rsv[0] || extoff->rsv[1]
> > +		    || (extoff->clockid != CLOCK_REALTIME
> > +			&& extoff->clockid != CLOCK_MONOTONIC_RAW)) {
> 
> Since you're touching this condition it's probably a good opportunity
> to fox the coding style.

What is the CodingStyle violation?

Is it starting a line with  ||  ?


Thanks,
Richard