netdev - Re: [PATCH v2 net] icmp: prevent possible NULL dereferences from icmp_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4013b9a0-7d7c-46e8-b579-68a3b06de2a3@kernel.org>
Date: Sat, 20 Apr 2024 19:09:41 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com,
 Andreas Roeseler <andreas.a.roeseler@...il.com>
Subject: Re: [PATCH v2 net] icmp: prevent possible NULL dereferences from
 icmp_build_probe()

On 4/20/24 1:01 AM, Eric Dumazet wrote:
> First problem is a double call to __in_dev_get_rcu(), because
> the second one could return NULL.
> 
> if (__in_dev_get_rcu(dev) && __in_dev_get_rcu(dev)->ifa_list)
> 
> Second problem is a read from dev->ip6_ptr with no NULL check:
> 
> if (!list_empty(&rcu_dereference(dev->ip6_ptr)->addr_list))
> 
> Use the correct RCU API to fix these.
> 
> v2: add missing include <net/addrconf.h>
> 
> Fixes: d329ea5bd884 ("icmp: add response to RFC 8335 PROBE messages")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Andreas Roeseler <andreas.a.roeseler@...il.com>
> ---
>  net/ipv4/icmp.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>