netdev - Re: [PATCH iproute2-next v2 2/2] f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41fc42a1-a0ed-4bbc-9bf5-d5876431497d@kernel.org>
Date: Sat, 20 Apr 2024 19:53:39 -0600
From: David Ahern <dsahern@...nel.org>
To: Wojciech Drewek <wojciech.drewek@...el.com>,
 Stephen Hemminger <stephen@...workplumber.org>
Cc: netdev@...r.kernel.org, dsahern@...il.com
Subject: Re: [PATCH iproute2-next v2 2/2] f_flower: implement pfcp opts

On 4/16/24 4:20 AM, Wojciech Drewek wrote:
> 
> 
> On 15.04.2024 23:52, Stephen Hemminger wrote:
>> On Mon, 15 Apr 2024 14:50:00 +0200
>> Wojciech Drewek <wojciech.drewek@...el.com> wrote:
>>
>>> 	} else if (key_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP]) {
>>> +		flower_print_pfcp_opts("pfcp_opt_key",
>>> +				key_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP],
>>> +				key, len);
>>> +
>>> +		if (msk_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP])
>>> +			flower_print_pfcp_opts("pfcp_opt_mask",
>>> +				msk_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP],
>>> +				msk, len);
>>> +
>>> +		flower_print_enc_parts(name, "  pfcp_opts %s", attr, key,
>>> +				       msk);
>>>  	}
>>
>> I find the output with pfcp_opt_key and pfcp_opt_mask encoded as hex,
>> awkward when JSON.
> 
> But we don't support JSON output for pfcp_opts.
> Do you want me to implement it?
> 

json support is preferred.