netdev - Re: [PATCH] tcp: Fix Use-After-Free in tcp_ao_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKpN_dnFsfxbhZsz_jcJ7OmP=5+AhmgkicCKC066qGxDQ@mail.gmail.com>
Date: Mon, 22 Apr 2024 12:39:16 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Hyunwoo Kim <v4bel@...ori.io>
Cc: 0x7f454c46@...il.com, imv4bel@...il.com, davem@...emloft.net, 
	dsahern@...nel.org, kuba@...nel.org, pabeni@...hat.com, 
	netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: Fix Use-After-Free in tcp_ao_connect_init

On Mon, Apr 22, 2024 at 11:33 AM Hyunwoo Kim <v4bel@...ori.io> wrote:
>
> Since call_rcu, which is called in the hlist_for_each_entry_rcu traversal
> of tcp_ao_connect_init, is not part of the RCU read critical section, it
> is possible that the RCU grace period will pass during the traversal and
> the key will be free.
>
> To prevent this, it should be changed to hlist_for_each_entry_safe.
>
> Fixes: 7c2ffaf21bd6 ("net/tcp: Calculate TCP-AO traffic keys")
> Signed-off-by: Hyunwoo Kim <v4bel@...ori.io>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !