netdev - Re: [PATCH] net: gtp: Fix Use-After-Free in gtp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKSxF1Nz-XjeeJ2Hv9BfbV1tULE0aq6S8xnT4pys1qvZw@mail.gmail.com>
Date: Mon, 22 Apr 2024 12:41:14 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Hyunwoo Kim <v4bel@...ori.io>
Cc: pablo@...filter.or, laforge@...monks.org, imv4bel@...il.com, 
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	osmocom-net-gprs@...ts.osmocom.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: gtp: Fix Use-After-Free in gtp_dellink

On Mon, Apr 22, 2024 at 11:39 AM Hyunwoo Kim <v4bel@...ori.io> wrote:
>
> Since call_rcu, which is called in the hlist_for_each_entry_rcu traversal
> of gtp_dellink, is not part of the RCU read critical section, it
> is possible that the RCU grace period will pass during the traversal and
> the key will be free.
>
> To prevent this, it should be changed to hlist_for_each_entry_safe.
>
> Fixes: 94dc550a5062 ("gtp: fix an use-after-free in ipv4_pdp_find()")
> Signed-off-by: Hyunwoo Kim <v4bel@...ori.io>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !